Update sample apps to work with OTel Python v1.3 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
approved these changes
Jun 22, 2021
| @@ -18,7 +18,7 @@ | |||
| # Setup AWS X-Ray Propagator | |||
|
|
|||
| # Propagators can be set using environment variable: OTEL_PROPAGATORS = aws_xray | |||
There was a problem hiding this comment.
Just curious why not use the environment variable?
There was a problem hiding this comment.
No particular reason! It's just that the 2 main components you need to get OTel Python to work with X-Ray is that:
- The IdsGenerator
- The Propagator
So I wanted those to be obvious from the source code here in the manual instrumentation instead of hiding them in environment variables in the script.
You can do the ID Generator from an environment variables too as of recent I think!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
OTel Python has changed the names of many things as part of their RC 1. In this PR we fix the imports and other bugs necessary to make the sample apps work with at least OTel Python 1.3.0
Noteworthy points
flask~=1.0because even though OTel Python instrumentation works withflask~=2.0they haven't updated their package to reflect that. Filed this PR to fix that.debug=Falsefor now. Production would be fine but I'm worried customers would find this bug difficult to resolve. Will investigate a little more and file an issue upstream.