Skip to content

TraceValidator #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Oct 22, 2020
Merged

TraceValidator #32

merged 13 commits into from
Oct 22, 2020

Conversation

bhautikpip
Copy link
Contributor

  1. Added trace validation logic
  2. Added http and aws pre stored json file
  3. tested with spring boot sample app

@bhautikpip bhautikpip requested a review from wyTrivail October 16, 2020 23:05
wyTrivail
wyTrivail reviewed Oct 17, 2020
View reviewed changes
wyTrivail
wyTrivail suggested changes Oct 17, 2020
View reviewed changes
Copy link
Contributor

@wyTrivail wyTrivail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some small comments, thanks!

@bhautikpip bhautikpip requested a review from wyTrivail October 19, 2020 22:22
wyTrivail
wyTrivail reviewed Oct 19, 2020
View reviewed changes
@bhautikpip bhautikpip requested a review from wyTrivail October 20, 2020 01:28
wyTrivail
wyTrivail approved these changes Oct 20, 2020
View reviewed changes
validator/src/main/java/com/amazon/aoc/helpers/RetryHelper.java Outdated
retryable.execute();
return;
} catch (Exception ex) {
log.error("exception during retry, you may ignore it", ex);
log.info("retrying after 10 seconds");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i remember the interval is a parameter, not a fixed 10 seconds

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure will add param here.

validator/src/main/java/com/amazon/aoc/helpers/RetryHelper.java
log.error("exception during retry, you may ignore it", ex);
log.info("retrying after 10 seconds");

if (retryCount == 0) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we move this out of the loop? since when the retries exhausted, it exit the loop

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the reason I kept that inside is because we can print the actual exception after retry is exhausted (why retry failed?).

@bhautikpip bhautikpip mentioned this pull request Oct 20, 2020
Merged
@bhautikpip bhautikpip linked an issue Oct 21, 2020 that may be closed by this pull request
[OTel-Test-Framework] Add Trace validator to validate trace data #36
Closed
@wyTrivail wyTrivail merged commit 8412a90 into aws-observability:terraform Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyTrivail wyTrivail wyTrivail approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[OTel-Test-Framework] Add Trace validator to validate trace data
2 participants
@bhautikpip @wyTrivail