Skip to content

chore(docs): output the Layer ARN to a artifact #1550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

rubenfonseca
Copy link
Contributor

Issue number: #1549

Summary

Changes

Please provide a summary of what's being changed

This PR automates the publishing of the layer version in our documetation for every release.
This will reduce maintance overhead, and make the publishing of the new layer version faster.

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@boring-cyborg boring-cyborg bot added dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation github-actions Pull requests that update Github_actions code labels Sep 28, 2022
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 28, 2022
@rubenfonseca rubenfonseca force-pushed the feat/cdk-layer-automation branch from 756c2c6 to df03119 Compare September 28, 2022 10:01
@pull-request-size pull-request-size bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 28, 2022
@rubenfonseca
Copy link
Contributor Author

@heitorlessa here's the beginning of the work as we discussed. What's missing is a way to incorporate the generated artfifacts, replace the version of the layer in our docs, and commit it back to the repo.

@github-actions github-actions bot added the internal Maintenance changes label Sep 28, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2022

Codecov Report

Base: 99.73% // Head: 99.73% // No change to project coverage 👍

Coverage data is based on head (df03119) compared to base (a74fda3).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1550   +/-   ##
========================================
  Coverage    99.73%   99.73%           
========================================
  Files          124      124           
  Lines         5713     5713           
  Branches       651      651           
========================================
  Hits          5698     5698           
  Misses           8        8           
  Partials         7        7           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@heitorlessa
Copy link
Contributor

Last PR and we're DONE with the major work for v2 🎉 !

@rubenfonseca
Copy link
Contributor Author

Closed in flavour of #1610

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation github-actions Pull requests that update Github_actions code internal Maintenance changes size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: create mechanism to auto publish the layer version for every release
3 participants