Skip to content

chore(dep): add cfn-lint as a dev dependency #1612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 18, 2022

Conversation

heitorlessa
Copy link
Contributor

Issue number: #1378

Summary

Since cfn-lint 0.64, we were unable to add as a dev dependency due to Python 3.6 being dropped. Powertools v2 drops support for v2.

Changes

Please provide a summary of what's being changed

This PR adds cfn-lint as a dev dependency, and updates pre-commit config to use it over Docker. This should also speed up CI checks and Release by a few seconds.

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@heitorlessa heitorlessa requested a review from a team as a code owner October 18, 2022 10:01
@heitorlessa heitorlessa requested review from am29d and removed request for a team October 18, 2022 10:01
@boring-cyborg boring-cyborg bot added dependencies Pull requests that update a dependency file internal Maintenance changes labels Oct 18, 2022
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 18, 2022
@heitorlessa heitorlessa requested review from rubenfonseca and removed request for am29d October 18, 2022 10:03
@heitorlessa heitorlessa merged commit ec96b14 into aws-powertools:v2 Oct 18, 2022
@heitorlessa heitorlessa deleted the chore/cfn-lint-dev-dep branch October 18, 2022 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file internal Maintenance changes size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants