Skip to content

chore(ci): remove v1 workflows #1617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rubenfonseca
Copy link
Contributor

@rubenfonseca rubenfonseca commented Oct 19, 2022

Issue number: #1616

Summary

Changes

Please provide a summary of what's being changed

Removes workflows related to creating the v1 layer, which we will not use on v2.
Removes dangerous workflows from v2 that would overite commits in develop.
Switches to workflow_calls on the laye workflow.

User experience

Please share what the user experience looks like before and after this change

This prepares us to merge v2 into develop, and not call the old workflows when releasing a new version.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@boring-cyborg boring-cyborg bot added the github-actions Pull requests that update Github_actions code label Oct 19, 2022
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 19, 2022
@rubenfonseca rubenfonseca linked an issue Oct 19, 2022 that may be closed by this pull request
2 tasks
@github-actions github-actions bot added the internal Maintenance changes label Oct 19, 2022
@rubenfonseca rubenfonseca marked this pull request as ready for review October 19, 2022 08:50
@rubenfonseca rubenfonseca requested a review from a team as a code owner October 19, 2022 08:50
@rubenfonseca rubenfonseca requested review from leandrodamascena and heitorlessa and removed request for a team October 19, 2022 08:50
@rubenfonseca
Copy link
Contributor Author

On .github/workflows/on_release_notes.yml, filter the on: release trigger with the correct tag prefix

@rubenfonseca rubenfonseca marked this pull request as draft October 19, 2022 10:16
@rubenfonseca rubenfonseca marked this pull request as ready for review October 19, 2022 14:23
Copy link
Contributor

@leandrodamascena leandrodamascena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@heitorlessa
Copy link
Contributor

Looking...

@heitorlessa
Copy link
Contributor

LGTM except one thing - we're gonna need a Post-Launch list to automate V1 releases. For this PR, the if startsWith correctly limits Release Notes for V2 only - we'll need a workflow_dispatch to release V1.

That is:

  • Make changes to V1 -> Merge into v1
  • Use Workflow X to release V1.x --> PyPi, Lambda Layer, (SAR?)
  • Publish a new release notes for V1.x

@heitorlessa heitorlessa changed the title chore(github-actions): remove unused v1 workflows chore(ci): remove unused v1 workflows Oct 19, 2022
@heitorlessa heitorlessa changed the title chore(ci): remove unused v1 workflows chore(ci): remove v1 workflows Oct 19, 2022
@heitorlessa heitorlessa merged commit 4bba49c into aws-powertools:v2 Oct 19, 2022
@rubenfonseca
Copy link
Contributor Author

LGTM except one thing - we're gonna need a Post-Launch list to automate V1 releases. For this PR, the if startsWith correctly limits Release Notes for V2 only - we'll need a workflow_dispatch to release V1.

That is:

  • Make changes to V1 -> Merge into v1
  • Use Workflow X to release V1.x --> PyPi, Lambda Layer, (SAR?)
  • Publish a new release notes for V1.x

Thanks @heitorlessa tracking this here #1618

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github-actions Pull requests that update Github_actions code internal Maintenance changes size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: remove v1 workflows from v2 before merge
3 participants