-
Notifications
You must be signed in to change notification settings - Fork 421
fix(parser): S3Model Object Deleted omits size and eTag attr #1638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
Fixes ObjectRemoved API event, as they don't include these attributes. aws-powertools#1637 Signed-off-by: Diego Barreiro <[email protected]>
LGTM |
Codecov ReportBase: 99.76% // Head: 99.35% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #1638 +/- ##
===========================================
- Coverage 99.76% 99.35% -0.41%
===========================================
Files 127 128 +1
Lines 5884 5881 -3
Branches 668 373 -295
===========================================
- Hits 5870 5843 -27
- Misses 6 18 +12
- Partials 8 20 +12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
Issue number: #1637
Summary
Fixes S3
ObjectRemoved
API event, as they don't include some attributes attributes.Changes
eTag
as optional attribute inS3Model
.size
as optional attribute inS3Model
.Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
No.
Testing
Thanks @ran-isenberg for the unit tests! They are all passing:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.