Skip to content

fix(parser): fix EventBridgeModel when working with scheduled events #6134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 20, 2025

Conversation

leandrodamascena
Copy link
Contributor

Issue number: #6112

Summary

Changes

This PR improves EventBridge Scheduler payload validation. It converts "{}" strings to empty dictionaries for AWS Scheduler events. This change prevents parsing errors and enhances event processing reliability, especially for events with empty payloads.

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@leandrodamascena leandrodamascena requested a review from a team as a code owner February 20, 2025 16:48
@boring-cyborg boring-cyborg bot added the tests label Feb 20, 2025
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 20, 2025
@leandrodamascena leandrodamascena self-assigned this Feb 20, 2025
@leandrodamascena leandrodamascena linked an issue Feb 20, 2025 that may be closed by this pull request
@github-actions github-actions bot added the bug Something isn't working label Feb 20, 2025
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.19%. Comparing base (240177d) to head (e6cd557).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #6134   +/-   ##
========================================
  Coverage    96.19%   96.19%           
========================================
  Files          235      235           
  Lines        11226    11229    +3     
  Branches       828      828           
========================================
+ Hits         10799    10802    +3     
  Misses         337      337           
  Partials        90       90           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leandrodamascena leandrodamascena merged commit 3544ea6 into develop Feb 20, 2025
12 checks passed
@leandrodamascena leandrodamascena deleted the fix/parser-event-bridge-model branch February 20, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: ValidationError for EventBridgeModel
2 participants