Skip to content

fix(metrics): ensure proper type conversion for DD_FLUSH_TO_LOG env var #6280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 18, 2025

Conversation

leandrodamascena
Copy link
Contributor

Issue number: #6255

Summary

Changes

This pull request addresses an issue with the type checking and conversion of the DD_FLUSH_TO_LOG environment variable in the metrics module. Previously, the type handling was inconsistent, which could lead to unexpected behavior when the environment variable was set as a string.

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@leandrodamascena leandrodamascena requested a review from a team as a code owner March 17, 2025 21:05
@boring-cyborg boring-cyborg bot added dependencies Pull requests that update a dependency file metrics tests labels Mar 17, 2025
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 17, 2025
@leandrodamascena leandrodamascena linked an issue Mar 17, 2025 that may be closed by this pull request
@leandrodamascena leandrodamascena self-assigned this Mar 17, 2025
@github-actions github-actions bot added the bug Something isn't working label Mar 17, 2025
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 17, 2025
@boring-cyborg boring-cyborg bot added the internal Maintenance changes label Mar 18, 2025
@github-actions github-actions bot removed the internal Maintenance changes label Mar 18, 2025
@boring-cyborg boring-cyborg bot added the internal Maintenance changes label Mar 18, 2025
@github-actions github-actions bot removed the internal Maintenance changes label Mar 18, 2025
Copy link

codecov bot commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.31%. Comparing base (2b1a5bb) to head (2dddf1c).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #6280   +/-   ##
========================================
  Coverage    96.31%   96.31%           
========================================
  Files          241      241           
  Lines        11625    11627    +2     
  Branches       862      863    +1     
========================================
+ Hits         11197    11199    +2     
  Misses         336      336           
  Partials        92       92           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@leandrodamascena leandrodamascena merged commit f5b4e1f into develop Mar 18, 2025
12 checks passed
@leandrodamascena leandrodamascena deleted the fix/datadogenvvar branch March 18, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file metrics size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: DD_FLUSH_TO_LOG = False flushes to log
2 participants