-
Notifications
You must be signed in to change notification settings - Fork 418
Feat/masking input types support #6412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
VatsalGoel3
wants to merge
10
commits into
aws-powertools:develop
from
VatsalGoel3:feat/masking-input-types-support
Closed
Feat/masking input types support #6412
VatsalGoel3
wants to merge
10
commits into
aws-powertools:develop
from
VatsalGoel3:feat/masking-input-types-support
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and standard classes (aws-powertools#3473)
|
@leandrodamascena, for now I applied the prepare_data() function as you suggested in the Issue, but I have an idea for making the function more robust and covering more edge cases, it would be like
If that is more relevant, will implement this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #3473
Summary
Changes
This PR adds support to the DataMasking utility to handle complex Python input types such as:
.dict()
methodTo support this, a new
prepare_data
function was introduced, which performs type introspection and converts the input data into a dictionary before processing.This function is now invoked at the beginning of the
erase
,encrypt
, anddecrypt
methods, allowing these methods to seamlessly accept structured objects in addition to primitive types likedict
,str
,list
, etc.User experience
Before:
After:
This allows customers to use the utility directly with modern application architectures that use type-safe data structures.
Checklist
Is this a breaking change?
RFC issue number: N/A
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.