-
Notifications
You must be signed in to change notification settings - Fork 429
feat(event_source): export SQSRecord in data_classes module #6639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(event_source): export SQSRecord in data_classes module #6639
Conversation
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
This doesn't fix a bug, as developers can already import SQSRecord directly from the submodule. The intent is simply to make the API more consistent and intuitive by allowing SQSEvent and SQSRecord to be imported from the same place, which aligns with how other event types are handled in the library. |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6639 +/- ##
========================================
Coverage 96.12% 96.12%
========================================
Files 253 253
Lines 12104 12104
Branches 902 902
========================================
Hits 11635 11635
Misses 369 369
Partials 100 100 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for improving this experience @AlisonVilela! Approving!
Obrigado 🇧🇷 |
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
Issue number: #6637
Summary
Changes
Export
SQSRecord
class in the mainaws_lambda_powertools.utilities.data_classes
module to allow for more consistent import patterns when working with SQS events.User experience
Before:
Developers need to use inconsistent import patterns:
After:
Developers can use a single, consistent import pattern:
This improves developer experience by providing a more intuitive API when working with SQS events.
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.