Skip to content

chore: change license #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 20, 2021
Merged

chore: change license #117

merged 2 commits into from
Jul 20, 2021

Conversation

dreamorosi
Copy link
Contributor

@dreamorosi dreamorosi commented Jul 16, 2021

Description of your changes

Modified license to reflect the correct one used in the Python version.

How to verify this change

See README file (towards the end) + LICENSE file.

Related issues, RFCs

Closes #116

PR status

Is this ready for review?: YES
Is it a breaking change?: NO

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published in downstream module
  • The PR title follows the conventional commit semantics

Breaking change checklist

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dreamorosi dreamorosi added the bug Something isn't working label Jul 16, 2021
@dreamorosi dreamorosi added this to the beta-release milestone Jul 16, 2021
@dreamorosi dreamorosi self-assigned this Jul 20, 2021
Copy link
Contributor

@saragerion saragerion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Copy link
Contributor

@alan-churley alan-churley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dreamorosi dreamorosi merged commit a30fe6e into main Jul 20, 2021
@dreamorosi dreamorosi deleted the chore/license branch July 20, 2021 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: Use correct license
3 participants