Skip to content

chore: add install step in docs workflow #1183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 24, 2022
Merged

Conversation

dreamorosi
Copy link
Contributor

Description of your changes

This PR reintroduces an install step in the workflow that publishes the docs, which is currently failing.

How to verify this change

Check the workflow outputs after merging.

Related issues, RFCs

Issue number: #1182

PR status

Is this ready for review?: YES
Is it a breaking change?: NO

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding changes to the examples
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published
  • The PR title follows the conventional commit semantics

Breaking change checklist

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pull-request-size pull-request-size bot added the size/S PR between 10-29 LOC label Nov 24, 2022
@dreamorosi dreamorosi self-assigned this Nov 24, 2022
@dreamorosi dreamorosi marked this pull request as ready for review November 24, 2022 16:54
@dreamorosi dreamorosi added the internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) label Nov 24, 2022
@dreamorosi dreamorosi merged commit 16529fc into main Nov 24, 2022
@dreamorosi dreamorosi deleted the chore/add_install_step_docs branch November 24, 2022 16:55
@dreamorosi dreamorosi linked an issue Nov 25, 2022 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) size/S PR between 10-29 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: Docs workflow is failing
1 participant