Skip to content

chore(tracer): apply UA to AWS SDK clients used by Tracer #1575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2023
Merged

chore(tracer): apply UA to AWS SDK clients used by Tracer #1575

merged 1 commit into from
Jul 4, 2023

Conversation

am29d
Copy link
Contributor

@am29d am29d commented Jul 4, 2023

Description of your changes

applied user agent to tracer

Related issues, RFCs

Issue number: closes #1539

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my change is effective and works
  • The PR title follows the conventional commit semantics

Breaking change checklist

Is it a breaking change?: NO

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@am29d am29d requested a review from a team July 4, 2023 10:27
@boring-cyborg boring-cyborg bot added tracer This item relates to the Tracer Utility tests PRs that add or change tests labels Jul 4, 2023
@pull-request-size pull-request-size bot added the size/S PR between 10-29 LOC label Jul 4, 2023
@am29d am29d changed the title Maintenance(tracer): apply UA to AWS SDK clients used by Tracer maintenance(tracer): apply UA to AWS SDK clients used by Tracer Jul 4, 2023
@am29d
Copy link
Contributor Author

am29d commented Jul 4, 2023

e2e tests ✅ https://github.com/aws-powertools/powertools-lambda-typescript/actions/runs/5453643388

@am29d am29d changed the title maintenance(tracer): apply UA to AWS SDK clients used by Tracer chore(tracer): apply UA to AWS SDK clients used by Tracer Jul 4, 2023
@am29d am29d requested review from dreamorosi and removed request for a team July 4, 2023 13:04
@dreamorosi dreamorosi mentioned this pull request Jul 4, 2023
Merged
9 tasks
dreamorosi
dreamorosi approved these changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great!

I have left a comment in the other PR #1577 related to this one, but I don't expect the changes to impact this part of the code (maybe the addUserAgentMiddleware), so it's safe to merge.

@dreamorosi dreamorosi merged commit f4687b4 into aws-powertools:main Jul 4, 2023
@dreamorosi dreamorosi mentioned this pull request Jul 5, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreamorosi dreamorosi dreamorosi approved these changes

Assignees

@am29d am29d

Labels
size/S PR between 10-29 LOC tests PRs that add or change tests tracer This item relates to the Tracer Utility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Maintenance: apply UA to AWS SDK clients used by Tracer
2 participants
@am29d @dreamorosi