Skip to content

docs(idempotency): add batch integration to idempotency docs #1676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 13, 2023
Merged

docs(idempotency): add batch integration to idempotency docs #1676

merged 3 commits into from
Sep 13, 2023

Conversation

am29d
Copy link
Contributor

@am29d am29d commented Sep 13, 2023

Description of your changes

This PR adds an example how to use batch processing in combination with idempotency.

Related issues, RFCs

Issue number: closes #1675

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my change is effective and works
  • The PR title follows the conventional commit semantics

Breaking change checklist

Is it a breaking change?: NO

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@am29d am29d requested a review from a team September 13, 2023 16:43
@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Sep 13, 2023
@pull-request-size pull-request-size bot added the size/L PRs between 100-499 LOC label Sep 13, 2023
@am29d
Copy link
Contributor Author

am29d commented Sep 13, 2023

WebStorm autoformatted bunch of useless stuff again 🫠.

@am29d am29d requested review from dreamorosi and removed request for a team September 13, 2023 16:44
@am29d am29d self-assigned this Sep 13, 2023
@am29d am29d added this to the Idempotency - GA Release milestone Sep 13, 2023
@am29d am29d added the idempotency This item relates to the Idempotency Utility label Sep 13, 2023
@pull-request-size pull-request-size bot added size/M PR between 30-99 LOC and removed size/L PRs between 100-499 LOC labels Sep 13, 2023
@pull-request-size pull-request-size bot added size/L PRs between 100-499 LOC and removed size/M PR between 30-99 LOC labels Sep 13, 2023
@dreamorosi dreamorosi self-requested a review September 13, 2023 22:44
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

dreamorosi
dreamorosi approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the imports, highlights, and registered context.

Thanks for the PR & welcome back!

@dreamorosi dreamorosi merged commit 81f2d69 into main Sep 13, 2023
@dreamorosi dreamorosi deleted the 1675-add-batch-to-idempotency-docs branch September 13, 2023 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreamorosi dreamorosi dreamorosi approved these changes

Assignees

@am29d am29d

Labels
documentation Improvements or additions to documentation idempotency This item relates to the Idempotency Utility size/L PRs between 100-499 LOC
Projects
None yet
Milestone
Idempotency - GA Release
Development

Successfully merging this pull request may close these issues.

Docs: add Batch Processing integration section to Idempotency
2 participants
@am29d @dreamorosi