chore(cicd): Add release workflow #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreamorosi
previously approved these changes
Dec 7, 2021
saragerion
reviewed
Dec 13, 2021
packages/logger/tests/unit/formatter/PowertoolLogFormatter.test.ts
Outdated
Show resolved
Hide resolved
|
Will open a new one with better way of handling |
…ertools-typescript into chore/releaseFlow
saragerion
reviewed
Dec 16, 2021
CONTRIBUTING.md
Outdated
| You can build and start a local docs website by running these two commands. | ||
| - `npm run docs-buildDockerImage` OR `docker build -t squidfunk/mkdocs-material ./docs/` | ||
| - `npm run docs-runLocalDocker` OR `docker run --rm -it -p 8000:8000 -v ${PWD}:/docs squidfunk/mkdocs-material` | ||
|
|
There was a problem hiding this comment.
Can you add a section on all the steps that need to be done to successfully create a release?
For instance: was the changelog generated automatically? Anything manually we need to do?
There was a problem hiding this comment.
no manual step needed. all done automatically. only constraint already mention in doc is follow semantic pull requests
saragerion
reviewed
Dec 17, 2021
packages/logger/README.md
Outdated
| @@ -27,7 +27,7 @@ npm run example:ephemeral-attributes | |||
| ```typescript | |||
| // Import the library | |||
| import { Logger } from '../src'; | |||
| // When going public, it will be something like: import { Logger } from '@aws-lambda-powertools/logger'; | |||
| // When going public, it will be something like: import { Logger } from '@flochaz/logger'; | |||
There was a problem hiding this comment.
oops? I guess it should be @aws-lambda-powertools?
saragerion
reviewed
Dec 17, 2021
| "main": "./lib/packages/metrics/src/index.js", | ||
| "types": "./lib/packages/metrics/src/index.d.ts", | ||
| "main": "./lib/index.js", | ||
| "types": "./lib/index.d.ts", |
saragerion
previously approved these changes
Dec 17, 2021
flochaz
force-pushed
the
chore/releaseFlow
branch
from
805b1be to
d2805e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
How to verify this change
Ran in provate repo:
https://github.com/flochaz/aws-lambda-powertools-typescript/releases
Output:
0.1.0-beta.0 (2021-12-06)
Bug Fixes
Features
Related issues, RFCs
#136
PR status
Is this ready for review?: NO
Is it a breaking change?: NO
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.