Skip to content

feat: generate api docs #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 12, 2021
Merged

feat: generate api docs #277

merged 9 commits into from
Dec 12, 2021

Conversation

ijemmy
Copy link
Contributor

@ijemmy ijemmy commented Dec 8, 2021

Description of your changes

  • Add TypeDoc to generate API docs. This can be run via npm run docs-generateApiDoc. The command will generate /api folder (gitignored) with TypeDoc.
  • Edit on-docs-change.yml Github workflow to also generate API doc and put this on 'develop/api' folder. This follows the same convention of Python version (/api)
  • For the home page of the API Doc, we are using README.md content. We can change this in the future if needed by editing the config file typedoc.js

How to verify this change

  1. Check out gh-pages branch
  2. Run npx live-server
  3. Open link "API reference" on the left-hand menu.

Related issues, RFCs

#152

PR status

Is this ready for review?: YES
Is it a breaking change?: NO

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published in downstream module
  • The PR title follows the conventional commit semantics

Breaking change checklist

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ijemmy ijemmy changed the title feat/generate api docs feat: generate api docs Dec 8, 2021
Comment on lines +7 to +9
"workspaces": [
"packages/*"
],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is required for multi-repo with TypeDoc.

@ijemmy ijemmy marked this pull request as ready for review December 8, 2021 16:31
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Homepage of API Docs has a broken image/badge:
image

Is this intended / due to the fact that the repo is still private? If yes please feel free to resolve the discussion.

@dreamorosi dreamorosi added this to the beta-release milestone Dec 8, 2021
@dreamorosi dreamorosi added documentation Improvements or additions to documentation automation This item relates to automation labels Dec 8, 2021
@flochaz
Copy link
Contributor

flochaz commented Dec 9, 2021

Awesome !

@flochaz flochaz mentioned this pull request Dec 10, 2021
10 tasks
@flochaz
Copy link
Contributor

flochaz commented Dec 10, 2021

Homepage of API Docs has a broken image/badge: image

Is this intended / due to the fact that the repo is still private? If yes please feel free to resolve the discussion.

I think it's indeed due to not being public

@dreamorosi dreamorosi mentioned this pull request Dec 10, 2021
10 tasks
@flochaz flochaz merged commit 64591f6 into main Dec 12, 2021
@flochaz flochaz deleted the feat/generate-api-docs branch December 12, 2021 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants