-
Notifications
You must be signed in to change notification settings - Fork 153
feat(logger): Add log buffer and flush method #3617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(logger): Add log buffer and flush method #3617
Conversation
This commit implements basic buffering logic to the logger utility, and the `flushLogger` method for flushing the buffered logs.
c4c1f3d
to
fb896e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, Connor!
The PR is in a really good state already, I have left a few minor comments mainly about project conventions and similar, but the implementation looks good overall.
I haven't focused too much on tests beyond looking at coverage since I expect that we'll need to refactor some of them after we make the methods public.
While you address the comments, also please look at these from the SonarCloud scanning.
Tomorrow morning I'll do a quick test in a Lambda function mainly to validate the logic around the X-Ray trace ID and if everything looks good we'll merge it as soon as the feedback below is addressed.
Great work again!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on this Connor, and congrats for getting your first PR merged in this repo!
Summary
This PR implements basic buffering logic to the logger utility, and the
flushLogger
method for flushing the buffered logs.Changes
logBuffer
test files tologBufferStructures
test file.bufferLog
andflushBuffer
methods to the Logger class. The buffer functionality is disabled at the moment.Other things to note:
Issue number: closes #3590
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.