chore: switch codebase to default esm #3959
Merged
+306
−205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
dependencies
pull-request-size
bot
added
the
size/XL
svozza
approved these changes
May 22, 2025
|
@am29d this is a pre-requisite to eventually move to Zod v4, the diff is kinda large but it's really the same 4 files changed over and over across packages. I tested the build locally and it seems to work as before. |
|
Apologies for the notification - e2e tests are failing on the layers, will need to investigate further, but I won't be able to do it before tomorrow most likely. |
|
Found the issue and fixed it, now the tests are passing. I had forgot to switch one of the config files, e2e tests saved the day. |
…powertools-lambda-typescript into chore/switch_esm_default
|
am29d
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
This PR switches the two
tsconfig.jsonfiles at the top level to use ESM first, and updates all the child configs accordingly.The reason behind this change is explained in details in the linked issue.
Issue number: closes #3958
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.