Skip to content

build(all): fix vm2 vulnerability #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 23, 2022

Conversation

ijemmy
Copy link
Contributor

@ijemmy ijemmy commented Feb 22, 2022

Description of your changes

Fix vm2 vulnerability (from aws-cdk) by running npm audit fix in every

How to verify this change

  1. Run e2e tests to see that there is no broken change. aws-cdk is used in E2E tests for utility packages.
  2. Run npx run cdk synth on cdk/example folder

Related issues, RFCs

N/A

PR status

Is this ready for review?: NO
Is it a breaking change?: NO

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding changes to the examples
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published in downstream module
  • The PR title follows the conventional commit semantics

Breaking change checklist

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Sorry, something went wrong.

@ijemmy
Copy link
Contributor Author

ijemmy commented Feb 22, 2022

@ijemmy ijemmy marked this pull request as ready for review February 22, 2022 19:20
@dreamorosi
Copy link
Contributor

Upgrading aws-cdk to latest also fixes it, see #569

@ijemmy ijemmy merged commit 7dc70ca into main Feb 23, 2022
@ijemmy ijemmy deleted the ijemmy/fix-vm2-vulnerability-on-node14 branch February 23, 2022 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants