chore: updated depdendabot configs #766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
internal
ijemmy
approved these changes
Apr 20, 2022
Comment on lines
+4
to
+12
| # Maintain dependencies for Python | ||
| - package-ecosystem: "pip" | ||
| directory: "/docs" | ||
| schedule: | ||
| interval: "weekly" | ||
| day: "friday" | ||
| time: "05:00" | ||
| timezone: "Europe/Amsterdam" | ||
| open-pull-requests-limit: 20 |
There was a problem hiding this comment.
I have to say that this check scares me. It has been a while... :D
There was a problem hiding this comment.
Yes, but luckily we don't have that many dependencies (only 3) and we have been keeping them relatively up to date (see latest PR). But let's see...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
As discussed in #672 we would like to reduce the noise from Dependabot while still being up to date with the dependency ecosystem. This PR introduces the following changes:
Europe/Amsterdamtz)docs/requirements.txt, this was previously ignored.** I propose to set this number to 20 (default is 5) so to increase the chance that Dependabot will open most/all the PR at once. This will allow the maintainers to have a better idea of the amount of PR to handle on the day (Friday). The current behaviour of 5 at the time made it so that Dependabot would keep opening PRs every time one was merged causing frustration. Read more about this setting here.
How to verify this change
TBD
Related issues, RFCs
#672
PR status
Is this ready for review?: YES
Is it a breaking change?: NO
Checklist
Breaking change checklist
N/A
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.