support object key with characters need to be URI encoded #311
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
URI decode the parsed object key in ImageRequest class.
The change can cause missing image if the key existing on S3 is intentionally URI encoded. e.g. If the key of the object stored on S3 is
%E4%B8%AD%E6%96%87.jpg
, this change will cause the handler to look for object with the key中文.jpg
. The key in the request would have to be double URI decoded (%25E4%25B8%25AD%25E6%2596%2587.jpg
) to access that object.Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.