Skip to content

chore(docs): Update contributing for develop branch and PR steps #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 13, 2023
Merged

chore(docs): Update contributing for develop branch and PR steps #421

merged 3 commits into from
Jan 13, 2023

Conversation

dougtoppin
Copy link
Contributor

@dougtoppin dougtoppin commented Jan 5, 2023 •
edited
Loading

Description of changes:

CONTRIBUTING updates:

  • use develop branch
  • enable and check dependabot advisories
  • feature branch may be created
  • when filing Issue, include region in issue report

PR template:

  • add unit tests for all new code

README:

  • update node version

Checklist

  • 👋 I have run the unit tests, and all unit tests have passed.
  • ⚠️ This pull request might incur a breaking change.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

G-Lenz
G-Lenz reviewed Jan 6, 2023
View reviewed changes
G-Lenz
G-Lenz reviewed Jan 6, 2023
View reviewed changes
Copy link
Contributor

@G-Lenz G-Lenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there also be wording around the expectation that unit tests should be created along with the new changes in a PR?

schana
schana previously requested changes Jan 6, 2023
View reviewed changes
Copy link

@schana schana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has an extraneous merge commit that should be cleaned up before merging.

@dougtoppin dougtoppin requested a review from schana January 6, 2023 20:05
@dougtoppin dougtoppin dismissed schana’s stale review January 13, 2023 20:44

extraneous commit was removed

@dougtoppin dougtoppin merged commit 75c6b24 into aws-solutions:develop Jan 13, 2023
@dougtoppin dougtoppin deleted the docs/contributing branch January 19, 2023 17:34
@dougtoppin dougtoppin mentioned this pull request Jan 25, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsingh04 gsingh04 gsingh04 approved these changes

@G-Lenz G-Lenz G-Lenz approved these changes

@schana schana Awaiting requested review from schana

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dougtoppin @schana @gsingh04 @G-Lenz