Skip to content

feat: Fix log/metrics endpoints when fips enabled #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sydefz
Copy link
Contributor

@sydefz sydefz commented Mar 19, 2024

Description of changes:

Currently when setting AWS_USE_FIPS_ENDPOINT the cloudwatch agent doesn't use fips endpoints, this PR adds logic to adopt the correct fips and region endpoints for cloudwatch agent to send logs and metrics.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@chn217
Copy link
Contributor

chn217 commented Mar 19, 2024

Hi Paul,

Thanks for the pull request and for fixing the issue. The code changes look good to me. However, I noticed that there is an npm package vulnerability reported by npm audit. Could you please run npm audit fix to resolve the vulnerability and submit the pull request again with the updated package dependencies? This will help ensure that our project is secure and up-to-date with the latest package versions.

Thanks

@sydefz
Copy link
Contributor Author

sydefz commented Mar 19, 2024

@chn217 I tried to run npm audit fix but the result suggests no vulnerabilities, I'm on node v20.4.0

% npm audit
found 0 vulnerabilities

@sydefz
Copy link
Contributor Author

sydefz commented Mar 19, 2024

ah ignore the previous comment, im running it in a wrong folder. updating the PR now

@chn217
Copy link
Contributor

chn217 commented Mar 19, 2024

Thanks Paul.

@chn217 chn217 closed this Mar 19, 2024
@chn217 chn217 reopened this Mar 19, 2024
@chn217 chn217 merged commit 9364a57 into aws-solutions:main Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants