Skip to content

feat: Use proper cfn endpoint, update name tag to include tier #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2024

Conversation

sydefz
Copy link
Contributor

@sydefz sydefz commented May 21, 2024

Description of changes:

Update user_data for all component, to support fips cloudformation endpoint, controlled by AWS_USE_FIPS_ENDPOINT env var.
Update asg to include tier in instance name tag.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@chn217 chn217 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the fix.

@chn217 chn217 merged commit ccb372b into aws-solutions:main May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants