Skip to content

Fix Data Node Splitting in Tiers #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jcalfayan
Copy link

@jcalfayan jcalfayan commented Sep 17, 2024

Description of changes:

  • This PR fixes the problem that currently splitting the middleManager and historicals into separate tiers only works if both your Tier 1 and Tier 2 nodes have the same name.
    • For example:
      • Tier 1: data | Tier 2: data_tier2 👍
      • Tier 1: data | Tier 2: middleManager_tier2, historical_tier2 👎 (expected to work)
      • Tier 1: middleManager, historical | Tier 2: middleManager_tier2, historical_tier2 👍
      • Tier 1: middleManager, historical | Tier 2: data_tier2 👎 (expected to work)
  • The reason is that currently when we get the instance type information we expect the props.nodeType to exist which in the case of both tiers having the same node type, it will, otherwise it will not which will cause the deploy to fail since we will not be able to grab the AWS resource information since we will set the parameter to utils.getInstanceTypeInfo as an empty string.

@bios6
Copy link
Member

bios6 commented Oct 18, 2024

Thank you for your PR. We are working on incorporating this change on the v1.0.5 release

@bios6
Copy link
Member

bios6 commented Nov 7, 2024

This change was added into release v1.0.5 . Thanks!

@bios6 bios6 closed this Nov 7, 2024
jcalfayan pushed a commit to jcalfayan/scalable-analytics-using-apache-druid-on-aws that referenced this pull request Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants