feat: allow solution to config internal system user #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*This PR enables customisation on druid internal system user, once the cluster is provisioned owner can change the internal system user credentials in secret manager to customise it. The solution now pulls the system user secret and set username/password as environment variables, the variable is then handled in
render_druid_config.py
andcheck_druid_status.py
script so it applies to the entire cluster.We also updated
render_utils.py
to correctly handledict
properties. For example previously"druid.auth.authenticator.allowAll.initialInternalClientPassword": {"type": "environment", "variable": "DRUID_INTERNAL_CLIENT_PASSWORD"}
will be rendered as string into the file (properties[key] = str(value)
) which makes the final file has {'type': 'environment', 'variable': 'DRUID_INTERNAL_CLIENT_PASSWORD'} property value, this will cause druid to confuse about where to get the value fromINFO [main] org.apache.druid.guice.JsonConfigurator - Unable to parse value of property [druid.auth.authenticator.allowAll.initialInternalClientPassword] as a json object, using as is.
*By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.