feat: Make standalone CLI #1496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaynabors
force-pushed
the
chay/standalone-cli-binary
branch
from
4ecda42 to
a1e1f71
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1496 +/- ##
=======================================
Coverage 16.75% 16.75%
=======================================
Files 213 213
Lines 20704 20704
Branches 871 871
=======================================
Hits 3468 3468
Misses 17236 17236 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cwoolum
reviewed
May 6, 2025
| let md = ent.metadata().await?; | ||
|
|
||
| let modified_timestamp = md.modified()?.duration_since(std::time::UNIX_EPOCH)?.as_secs(); | ||
| let datetime = time::OffsetDateTime::from_unix_timestamp(modified_timestamp as i64).unwrap(); |
There was a problem hiding this comment.
This is probably a super unlikely scenario but if modified_timestamp is nil with the unwrap, wouldn't this panic?
There was a problem hiding this comment.
Thanks for pointing out, there shouldn't be unwraps like this in production code. Only ported whats on main 🤦
remove chat from q_cli give temporary name rename chat-cli crate checkpoint finish fixing lints support windows fix more osx lints fix: compile q and qchat on Linux bundle qchat with the desktop app fix: more broken lints on linux, remove unused code add q issue add chat execute add copying chat binary in appimage install port thinking tool port execute_bash summary from main fix build partial #1403 sdjifodjio run fmt
chaynabors
force-pushed
the
chay/standalone-cli-binary
branch
from
4f25dd0 to
df3940e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO