Skip to content

refactor: migrate to @bufbuild/protobuf for JS protobufs #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

grant0417
Copy link
Contributor

@grant0417 grant0417 commented Dec 20, 2024

Description of changes:

These changes move to using @buildbuf/protobuf a more modern alternative to ts-proto which was used before. Additionally the resulting bundle size for autocomplete is 100kB smaller than before which should help in integrations that require smaller bundle sizes.

Before:

639.64 kB │ gzip: 169.19 kB

After:

553.10 kB │ gzip: 170.90 kB

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@grant0417 grant0417 requested a review from a team December 20, 2024 03:08
@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 4.98008% with 477 lines in your changes missing coverage. Please review.

Project coverage is 12.34%. Comparing base (a753760) to head (178ef35).

Files with missing lines Patch % Lines
packages/api-bindings/src/requests.ts 0.64% 310 Missing ⚠️
packages/api-bindings/codegen/generate-requests.ts 0.00% 39 Missing ⚠️
packages/autocomplete/src/actions.ts 0.00% 21 Missing ⚠️
packages/api-bindings/src/history.ts 4.76% 20 Missing ⚠️
packages/api-bindings/src/filesystem.ts 7.14% 13 Missing ⚠️
packages/api-bindings/src/install.ts 0.00% 13 Missing ⚠️
packages/api-bindings/src/shell.ts 0.00% 12 Missing ⚠️
packages/api-bindings/src/core.ts 52.38% 10 Missing ⚠️
packages/api-bindings/src/notifications.ts 27.27% 8 Missing ⚠️
packages/api-bindings/src/position.ts 12.50% 7 Missing ⚠️
... and 9 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #295      +/-   ##
==========================================
- Coverage   12.34%   12.34%   -0.01%     
==========================================
  Files        2233     2233              
  Lines      189980   190080     +100     
  Branches   174665   174665              
==========================================
  Hits        23457    23457              
- Misses     165356   165456     +100     
  Partials     1167     1167              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grant0417 grant0417 merged commit 56251ad into aws:main Dec 20, 2024
10 checks passed
jlhood pushed a commit to jlhood/amazon-q-developer-cli that referenced this pull request Mar 16, 2025
* refactor: migrate to @bufbuild/protobuf for JS protobufs

* bump versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants