fix(toolkit-lib): remove deprecated options #307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #307 +/- ##
==========================================
- Coverage 85.58% 85.39% -0.20%
==========================================
Files 223 223
Lines 37002 37002
Branches 4493 4447 -46
==========================================
- Hits 31668 31597 -71
- Misses 5233 5313 +80
+ Partials 101 92 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aws-cdk-automation
had a problem deploying
to
integ-approval
GitHub Actions
Failure
mrgrain
force-pushed
the
mrgrain/fix/remove-deprecated-options
branch
from
07a05e1 to
6e67078
Compare
Remove deprecated options that have been replaced by IoHost functionality: - Remove `requireApproval` from DeployOptions (deprecated) - Remove `ci` and `progress` from DeployOptions (deprecated) - Remove `ci` from DestroyOptions (deprecated) - Remove related usage in toolkit.ts implementation BREAKING CHANGE: Removes previously deprecated options from Toolkit actions. From `DeployOptions`, removed the options `requireApproval`, `ci` and `progress`. From `DestroyOptions`, removed the option `ci`. All removed options were previously deprecated and had no functional effect. Instead you should implement desired functionality in your `IIoHost` implementation.
mrgrain
force-pushed
the
mrgrain/fix/remove-deprecated-options
branch
from
6e67078 to
d66bd2f
Compare
rix0rrr
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove deprecated options that have been replaced by IoHost functionality:
requireApprovalfrom DeployOptions (deprecated)ciandprogressfrom DeployOptions (deprecated)cifrom DestroyOptions (deprecated)BREAKING CHANGE: Removes previously deprecated options from toolkit actions. From
DeployOptions, removed the optionsrequireApproval,ciandprogress. FromDestroyOptions, removed the optionci. All removed options were previously deprecated and had no functional effect. Instead you should implement desired functionality in yourIIoHostimplementation.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license