feat(toolkit): watch operation can be stopped #308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #308 +/- ##
==========================================
+ Coverage 85.34% 85.44% +0.10%
==========================================
Files 222 222
Lines 36898 36926 +28
Branches 4451 4455 +4
==========================================
+ Hits 31492 31553 +61
+ Misses 5313 5277 -36
- Partials 93 96 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The `toolkit.watch()` operation used to start a filesystem watcher in the background and immediately return. The caller would continue running to its end, while the filesystem watcher would keep the node process alive. Instead, now return an `IWatcher` object that can be disposed to stop the watching, and can be used to wait for the watcher to stop.
rix0rrr
force-pushed
the
huijbers/watch-return-type
branch
from
fe845b2 to
486e70b
Compare
iliapolo
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
toolkit.watch()operation used to start a filesystem watcher in the background and immediately return. The caller would continue running to its end, while the filesystem watcher would keep the node process alive.Instead, now return an
IWatcherobject that can be disposed to stop the watching, and can be used to wait for the watcher to stop.Closes #299
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license