refactor(cli): make the cli use more shared code #207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrgrain
commented
Mar 7, 2025
| @@ -725,6 +725,8 @@ tmpToolkitHelpers.eslint?.addRules({ | |||
| '@typescript-eslint/consistent-type-imports': 'error', | |||
| }); | |||
|
|
|||
| tmpToolkitHelpers.gitignore.addPatterns('test/**/*.map'); | |||
There was a problem hiding this comment.
No idea how this file got there in the first place. But it won't anymore in future.
mrgrain
commented
Mar 7, 2025
| @@ -184,7 +184,7 @@ export const EVENT_TO_LEVEL: Record<EventType, IoMessageLevel | false> = { | |||
|
|
|||
| export abstract class BasePublishProgressListener implements IPublishProgressListener { | |||
| protected readonly ioHost: IIoHost; | |||
| protected readonly action: ToolkitAction; | |||
| protected readonly action: IoMessaging['action']; | |||
There was a problem hiding this comment.
Plan is to not have the action here but to have an ActionAwareIoHost. See importer.ts as an example. Eventually we will just be passing ActionAwareIoHost hosts around.
mrgrain
commented
Mar 7, 2025
| @@ -102,17 +103,15 @@ export class ResourceImporter { | |||
|
|
|||
| private readonly stack: cxapi.CloudFormationStackArtifact; | |||
| private readonly cfn: Deployments; | |||
| private readonly ioHost: IIoHost; | |||
| private readonly action: ToolkitAction; | |||
| private readonly ioHost: ActionAwareIoHost; | |||
mrgrain
commented
Mar 7, 2025
|
|
||
| constructor( | ||
| stack: cxapi.CloudFormationStackArtifact, | ||
| props: ResourceImporterProps, | ||
| ) { | ||
| this.stack = stack; | ||
| this.cfn = props.deployments; | ||
| this.ioHost = props.ioHost; | ||
| this.action = props.action; | ||
| this.ioHost = withAction(props.ioHost, props.action as any); |
There was a problem hiding this comment.
Almost the future. Eventually this class should just get an ActionAwareIoHost in the first place.
mrgrain
commented
Mar 7, 2025
| @@ -78,7 +78,7 @@ export async function exec(args: string[], synthesizer?: Synthesizer): Promise<n | |||
| debug(`Error while checking for platform warnings: ${e}`); | |||
| } | |||
|
|
|||
| debug('CDK toolkit version:', version.displayVersion()); | |||
| debug('CDK Toolkit CLI version:', version.displayVersion()); | |||
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #207 +/- ##
==========================================
- Coverage 85.27% 85.12% -0.16%
==========================================
Files 207 208 +1
Lines 35837 35775 -62
Branches 4656 4645 -11
==========================================
- Hits 30559 30452 -107
- Misses 5120 5171 +51
+ Partials 158 152 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mrgrain
force-pushed
the
mrgrain/refactor/cli-uses-shared-code
branch
from
9c39e7f to
7ef9d82
Compare
rix0rrr
approved these changes
Mar 7, 2025
mrgrain
force-pushed
the
mrgrain/refactor/cli-uses-shared-code
branch
from
4bbfb9d to
979c0d5
Compare
|
Added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes duplicated interfaces.
I know this is messy. Please bear with me 🙈
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license