refactor(cli): use IoHelper in internal APIs #209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrgrain
force-pushed
the
mrgrain/refactor/no-more-actions
branch
from
c3ff921 to
b49dfc4
Compare
mrgrain
commented
Mar 7, 2025
| @@ -107,7 +108,7 @@ export async function exec(args: string[], synthesizer?: Synthesizer): Promise<n | |||
| proxyAddress: argv.proxy, | |||
| caBundlePath: argv['ca-bundle-path'], | |||
| }, | |||
| logger: new SdkToCliLogger(ioHost), | |||
| logger: new SdkToCliLogger(asIoHelper(ioHost, ioHost.currentAction as any)), | |||
There was a problem hiding this comment.
ioHost.currentAction is extending ToolkitAction with additional values. This is fine.
Same again in L189
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #209 +/- ##
==========================================
+ Coverage 85.04% 85.26% +0.22%
==========================================
Files 208 208
Lines 35786 35710 -76
Branches 4633 4652 +19
==========================================
+ Hits 30435 30449 +14
+ Misses 5200 5111 -89
+ Partials 151 150 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mrgrain
commented
Mar 7, 2025
| @@ -391,35 +393,6 @@ test('reuse previous parameters if requested', async () => { | |||
| } as CreateChangeSetCommandInput); | |||
| }); | |||
|
|
|||
| describe('ci=true', () => { | |||
There was a problem hiding this comment.
deleted since this test was just testing that the CI dependent stream selection works.
mrgrain
force-pushed
the
mrgrain/refactor/no-more-actions
branch
from
172f0dd to
c6d756a
Compare
kaizencc
approved these changes
Mar 7, 2025
|
Added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a lot. There is no good way of reviewing it, so thanks for taking the time.
The main change here is the usage of the
IoHelperin all internal APIs. Previously we would pass anIoHostand anactionaround as pair, but separate value. Instead we now use theIoHelperwhich knows how to send messages with an action.I also decided to rename all properties and params respectively. This is partly what makes the PR so large. Note that all changes are to private APIs.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license