chore: fix versions in package.json
#281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependencies on packages in monorepo should always be `^0.0.0`. They will be changed into exact dependency versions, if necessary, at release time. Due to some previous attempts at implementing that workflow, some literal `"0.0.0"`'s had snuck into our `package.json`s, and `projen` leaves them at whatever they are. Now that we are explicitly setting versions back to `^0.0.0` at `unbump` time, that causes a diff with respect to the literal exact versions that are in the repo. Manually revert them to caret versions.
rix0rrr
had a problem deploying
to
integ-approval
GitHub Actions
Failure
rix0rrr
added
pr/exempt-integ-test
mrgrain
approved these changes
Mar 25, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #281 +/- ##
==========================================
+ Coverage 85.15% 85.47% +0.31%
==========================================
Files 221 221
Lines 36764 36764
Branches 4447 4480 +33
==========================================
+ Hits 31307 31423 +116
+ Misses 5359 5246 -113
+ Partials 98 95 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependencies on packages in monorepo should always be
^0.0.0. They will be changed into exact dependency versions, if necessary, at release time.Due to some previous attempts at implementing that workflow, some literal
"0.0.0"'s had snuck into ourpackage.jsons, andprojenleaves them at whatever they are.Now that we are explicitly setting versions back to
^0.0.0atunbumptime, that causes a diff with respect to the literal exact versions that are in the repo.Manually set them to caret versions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license