-
Notifications
You must be signed in to change notification settings - Fork 27
fix(cli): remove unnecessary dom
lib from default TypeScript config created with cdk init
#295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I expect this build to fail, since I explicitly included all the But we'll see... |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #295 +/- ##
==========================================
+ Coverage 85.28% 85.53% +0.24%
==========================================
Files 222 222
Lines 36926 36926
Branches 4437 4480 +43
==========================================
+ Hits 31492 31583 +91
+ Misses 5339 5247 -92
- Partials 95 96 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Head branch was pushed to by a user without write access
b99190b
to
178a366
Compare
Oh I see you're not making changes through |
Thanks for pointing that out! I confirmed that another package also relies on Also, since |
dom
lib from default TypeScript config created with cdk init
force merging because codecov failures are unrelated to this PR |
Fixes #294
This change also removes
"dom"
from thetsconfig.json
files of additional packages that are all intended to run in a Node.js environment, not in the browser.Since these packages are not expected to use any web runtime-specific APIs, removing
"dom"
helps prevent accidental use of browser-only types across the codebase.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license