-
Notifications
You must be signed in to change notification settings - Fork 27
refactor(toolkit): move the rest #338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaizencc
approved these changes
Apr 4, 2025
a9e3f74
to
bbbe67a
Compare
99cd08a
to
027fb53
Compare
027fb53
to
200aa8f
Compare
200aa8f
to
a963c6d
Compare
a963c6d
to
1952cfe
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #338 +/- ##
==========================================
- Coverage 85.72% 85.26% -0.47%
==========================================
Files 173 169 -4
Lines 22003 20524 -1479
Branches 2500 2284 -216
==========================================
- Hits 18862 17499 -1363
+ Misses 3093 2977 -116
Partials 48 48
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1952cfe
to
94e9675
Compare
Signed-off-by: github-actions <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the the rest of shared toolkit code to the helper package and removes the
toolkit-lib
s dependency on the CLI. Tests will be moved later to keep the diff size manageable. Code is still tested as the tests are still running from aws-cdk package.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license