Skip to content

refactor(toolkit): move the rest #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 4, 2025

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Apr 4, 2025

Moves the the rest of shared toolkit code to the helper package and removes the toolkit-libs dependency on the CLI. Tests will be moved later to keep the diff size manageable. Code is still tested as the tests are still running from aws-cdk package.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Apr 4, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team April 4, 2025 16:56
@mrgrain mrgrain force-pushed the mrgrain/refactor/move-context-providers branch from a9e3f74 to bbbe67a Compare April 4, 2025 17:07
Base automatically changed from mrgrain/refactor/move-context-providers to main April 4, 2025 17:19
@mrgrain mrgrain force-pushed the mrgrain/refactor/move-the-rest branch from 99cd08a to 027fb53 Compare April 4, 2025 17:24
@mrgrain mrgrain force-pushed the mrgrain/refactor/move-the-rest branch from 027fb53 to 200aa8f Compare April 4, 2025 18:12
@mrgrain mrgrain force-pushed the mrgrain/refactor/move-the-rest branch from 200aa8f to a963c6d Compare April 4, 2025 18:13
@mrgrain mrgrain force-pushed the mrgrain/refactor/move-the-rest branch from a963c6d to 1952cfe Compare April 4, 2025 18:15
@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.26%. Comparing base (5ce3aef) to head (da16896).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #338      +/-   ##
==========================================
- Coverage   85.72%   85.26%   -0.47%     
==========================================
  Files         173      169       -4     
  Lines       22003    20524    -1479     
  Branches     2500     2284     -216     
==========================================
- Hits        18862    17499    -1363     
+ Misses       3093     2977     -116     
  Partials       48       48              
Flag Coverage Δ
suite.unit 85.26% <100.00%> (-0.47%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mrgrain mrgrain force-pushed the mrgrain/refactor/move-the-rest branch from 1952cfe to 94e9675 Compare April 4, 2025 18:31
Signed-off-by: github-actions <[email protected]>
@aws-cdk-automation aws-cdk-automation added this pull request to the merge queue Apr 4, 2025
Merged via the queue into main with commit a9b456a Apr 4, 2025
20 checks passed
@aws-cdk-automation aws-cdk-automation deleted the mrgrain/refactor/move-the-rest branch April 4, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants