-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(ecs): Incorrect ECS Fargate cpu/memory settings are not detected #22216
(ecs): Incorrect ECS Fargate cpu/memory settings are not detected #22216
Comments
It would be nice to detect this before deployment. Do you know where we can read documentation on the exact specifications for these inputs? |
The three links given in the PR below are helpful. Allowable values in the 1st line, you can see whether or not there is a runtime constraint in the 2nd and 3rd lines |
It is also possible to define the CPU corresponding to memory as an enum, or vice versa. However, it is assumed that it is necessary to allow ″type number″ when considering backward compatibility. Therefore, the value check process is recognized with higher priority. |
Comments on closed issues and PRs are hard for our team to see. |
1 similar comment
Comments on closed issues and PRs are hard for our team to see. |
…E compatible task definitions (#33608) ### Issue # (if applicable) Closes #22216 ### Reason for this change ### Description of changes Trying to fix the cause of regression by adding a validation to see if values are tokens #31106 Added a validateFargateTaskDefinitionMemoryCpu method in the base task definition and run this validation when a task definition has FARGATE in requiresCompatibilities. This is in line with the ECS requirement that even if a task definition has EC2 compatibility (along with FARGATE), FARGATE validations apply ### Description of how you validated changes unit and integ tests and also the [previous issue](#31106 (comment)) ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…E compatible task definitions (aws#33608) ### Issue # (if applicable) Closes aws#22216 ### Reason for this change ### Description of changes Trying to fix the cause of regression by adding a validation to see if values are tokens aws#31106 Added a validateFargateTaskDefinitionMemoryCpu method in the base task definition and run this validation when a task definition has FARGATE in requiresCompatibilities. This is in line with the ECS requirement that even if a task definition has EC2 compatibility (along with FARGATE), FARGATE validations apply ### Description of how you validated changes unit and integ tests and also the [previous issue](aws#31106 (comment)) ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Describe the bug
Now this setting succeeds, but this is the wrong cpu/memory ratio for a Fargate setting.
It may be necessary to add a
checkFargateWindowsBasedTasksSize
type of determination method to Fargate as well!Expected Behavior
Before
cdk synth
, CDK will determine the wrong configuration.Current Behavior
Generate unsuccessful task definitions as CFn templates
Reproduction Steps
Here's the sample code I wrote above
Possible Solution
No response
Additional Information/Context
No response
CDK CLI Version
2.41.1
Framework Version
No response
Node.js Version
any
OS
any
Language
Typescript
Language Version
No response
Other information
No response
The text was updated successfully, but these errors were encountered: