Skip to content

fix(glue-alpha): inconsistent workflow addconditionalTrigger casing #33752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

apogeeoak
Copy link
Contributor

Issue #33751

Closes #33751.

Reason for this change

The conditional workflow trigger (addconditionalTrigger) in the aws-glue-alpha package contains inconsistent casing and should be updated to camel case.

Description of changes

Updated the conditional workflow trigger (addconditionalTrigger) to camel case (addConditionalTrigger).

Describe any new or updated permissions being added

None.

Description of how you validated changes

Updated existing unit and integration tests, aws-glue-alpha/test/integ.workflow.ts and aws-glue-alpha/test/workflow-triggers.test.ts.

Checklist

BREAKING CHANGE: Updated casing of workflow.addconditionalTrigger to workflow.addConditionalTrigger.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team March 12, 2025 16:14
@github-actions github-actions bot added bug This issue is a bug. p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Mar 12, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@apogeeoak
Copy link
Contributor Author

apogeeoak commented Mar 12, 2025

Exemption Request: The fix contains a change to the integration test file, but the resulting snapshot remains unchanged as only the user facing API was updated.

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Mar 12, 2025
@GavinZZ GavinZZ self-assigned this Mar 12, 2025
@GavinZZ GavinZZ added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Mar 12, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review March 12, 2025 16:37

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Copy link
Contributor

mergify bot commented Mar 12, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.38%. Comparing base (55a3c4c) to head (6f1ae91).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #33752   +/-   ##
=======================================
  Coverage   82.38%   82.38%           
=======================================
  Files         120      120           
  Lines        6937     6937           
  Branches     1170     1170           
=======================================
  Hits         5715     5715           
  Misses       1119     1119           
  Partials      103      103           
Flag Coverage Δ
suite.unit 82.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk ∅ <ø> (∅)
packages/aws-cdk-lib/core 82.38% <ø> (ø)
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 6f1ae91
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 4886a3e into aws:main Mar 12, 2025
20 checks passed
Copy link
Contributor

mergify bot commented Mar 12, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2025
@apogeeoak apogeeoak deleted the fix/glue-alpha/inconsistent-workflow-addconditionaltrigger-casing branch March 12, 2025 17:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

glue-alpha: inconsistent workflow addconditionalTrigger casing
3 participants