Skip to content

fix(glue-alpha): inconsistent workflow addconditionalTrigger casing #33752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 12, 2025
Merged

fix(glue-alpha): inconsistent workflow addconditionalTrigger casing #33752

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ea151a
fix(glue-alpha): inconsistent workflow addconditionalTrigger casing
apogeeoak Mar 12, 2025
6f1ae91
Merge branch 'main' into fix/glue-alpha/inconsistent-workflow-addcond…
mergify[bot] Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/@aws-cdk/aws-glue-alpha/lib/triggers/workflow.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ export abstract class WorkflowBase extends cdk.Resource implements IWorkflow {
* @throws If a job is provided without a job state, or if a crawler is provided without a crawler state for any condition.
* @returns The created CfnTrigger resource.
*/
public addconditionalTrigger(id: string, options: ConditionalTriggerOptions): CfnTrigger {
public addConditionalTrigger(id: string, options: ConditionalTriggerOptions): CfnTrigger {
const trigger = new CfnTrigger(this, id, {
...options,
workflowName: this.workflowName,
Expand Down
2 changes: 1 addition & 1 deletion packages/@aws-cdk/aws-glue-alpha/test/integ.workflow.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ workflow.addOnDemandTrigger('OnDemandTrigger', {
actions: [{ job: InboundJob }],
});

workflow.addconditionalTrigger('ConditionalTrigger', {
workflow.addConditionalTrigger('ConditionalTrigger', {
actions: [{ job: OutboundJob }],
predicate: {
conditions: [
Expand Down
2 changes: 1 addition & 1 deletion packages/@aws-cdk/aws-glue-alpha/test/workflow-triggers.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ describe('Workflow and Triggers', () => {
});

test('creates a workflow with conditional trigger', () => {
workflow.addconditionalTrigger('ConditionalTrigger', {
workflow.addConditionalTrigger('ConditionalTrigger', {
actions: [{ job }],
predicate: {
conditions: [
Expand Down