Skip to content

chore: fix lfs files that should have been pointers but aren't #33413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Feb 12, 2025

Reason for this change

When checking out a fresh copy of the repo you are currently greeted with this message:

Encountered 32 file(s) that should have been pointers, but weren't:
  [list of the 32 files]

Additionally, when changing branches or updating branches some of these files frequently end up in a state that is confusing git, thus making it almost impossible to with the repo.

It appears that these files have not been migrated to lfs correctly.

Description of changes

Run the following command to fix the files:

git lfs migrate import --no-rewrite [list of the 32 files]

Describe any new or updated permissions being added

n/a

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team February 12, 2025 15:07
@github-actions github-actions bot added the p2 label Feb 12, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Feb 12, 2025
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.91%. Comparing base (92a9a73) to head (889a074).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #33413   +/-   ##
=======================================
  Coverage   80.91%   80.91%           
=======================================
  Files         236      236           
  Lines       14258    14258           
  Branches     2492     2492           
=======================================
  Hits        11537    11537           
  Misses       2436     2436           
  Partials      285      285           
Flag Coverage Δ
suite.unit 80.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 79.74% <ø> (ø)
packages/aws-cdk-lib/core 82.18% <ø> (ø)

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 889a074
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Feb 12, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 80f741c into main Feb 12, 2025
36 checks passed
@mergify mergify bot deleted the mrgrain/chore/fix-lfs branch February 12, 2025 15:38
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants