feat(ec2): implement IPeer to PrefixList to be usable as a connection peer

[Tietew]

Issue # (if applicable)

Closes #33607.

Reason for this change

When we want to add a security group rule with PrefixList as a connection peer,
we should write redundant prefixList:

const pl = new ec2.PrefixList(this, 'PrefixList', { ... });
instance.connections.allowFrom(ec2.Peer.prefixList(pl.prefixListId), ec2.Port.XXX);

This PR allows us to write DRY:

const pl = new ec2.PrefixList(this, 'PrefixList', { ... });
instance.connections.allowFrom(pl, ec2.Port.XXX);

Description of changes

• Modify the IPrefixList interface to extend IPeer
• Implement the required IPeer methods in PrefixListBase

Describe any new or updated permissions being added

Nothing

Description of how you validated changes

Added unit tests and updated an integ test.

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.38%. Comparing base (7f2ed96) to head (c209b9b).

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #33617   +/-   ##
=======================================
  Coverage   82.38%   82.38%           
=======================================
  Files         120      120           
  Lines        6938     6938           
  Branches     1170     1170           
=======================================
  Hits         5716     5716           
  Misses       1119     1119           
  Partials      103      103           

Flag	Coverage Δ
suite.unit	82.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
packages/aws-cdk	∅ <ø> (∅)
packages/aws-cdk-lib/core	82.38% <ø> (ø)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[aws-cdk-automation]

(This review is outdated)

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[Tietew]

@ozelalisen Added same jsdocs as IPeer

[ozelalisen]

Sorry, I missed one major issue with this PR previously. So I have the following concern:

• Extending IPrefixList with IPeer represents a backwards compatibility concern since any existing class that implements IPrefixList would now be required to implement additional IPeer interface methods, which would break existing custom implementations for clients.

[Tietew]

Oops!

How about introducing a new interface inherits IPrefixList and IPeer?

// A new interface
export interface IPrefixListWithPeer extends IPrefixList, IPeer { };

// PrefixListBase implements the new interface
abstract class PrefixListBase extends Resource implements IPrefixListWithPeer {
  /* implement IPeer */
}

// PrefixList.fromXXX() returns the new interface
export class PrefixList extends PrefixListBase {
  public static fromPrefixListId(...): IPrefixListWithPeer;
  public static fromLookup(...): IPrefixListWithPeer;
}

[Tietew]

error: [awslint:from-signature:aws-cdk-lib.aws_ec2.PrefixList.fromPrefixListId] invalid method signature for fromXxx method. If the construct is using the "constructs" module, set the environment variable "AWSLINT_BASE_CONSTRUCT" and re-run (expected="aws-cdk-lib.aws_ec2.IPrefixList",actual="aws-cdk-lib.aws_ec2.IPrefixListWithPeer")

awslint failed. any solution?

[ozelalisen]

@Tietew Sorry about the confusion on this! We had a discussion internally, and your changes by extending IPrefixList does not count as a breaking change, since it is related to implementation upgradability. Your changes are looking good, I will approve your PR.

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: c15a536
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[github-actions]

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.