Skip to content

fix: t_local_cache_threading.c:85:12: error: incompatible pointer to integer conversion #808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dawesc
Copy link

@dawesc dawesc commented Nov 21, 2024

Unable to compile on Mac without a static cast to ensure the return type of the thread id.

Issue #807

Description of changes:
Static cast the thread pointer returned so that on MacOs it compiles

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

@dawesc dawesc requested a review from a team as a code owner November 21, 2024 09:02
@dawesc dawesc had a problem deploying to continuous-integration November 21, 2024 16:48 — with GitHub Actions Failure
@dawesc dawesc had a problem deploying to continuous-integration November 21, 2024 16:48 — with GitHub Actions Error
@texastony
Copy link
Contributor

texastony commented Nov 21, 2024

Copying some testing logs from the CodeBuild execution on Identifier: build_test_static_debug:

43/43 Test #4: static_test_vectors ........................***Failed 204.50 sec

Decryption successfully completed for 8208 test cases and failed for 1.
AES Passed = 4901, RSA Passed = 1320, KMS Passed = 1320, Encrypt-only = 0, Not-yet-supported = 880.

98% tests passed, 1 tests failed out of 43
Total Test time (real) = 204.55 sec
The following tests FAILED:
      4 - static_test_vectors (Failed)

I do not have time to dig into these right now,
but it appears that only one static test vector failed.

I kicked off a retry, on the chance that it was a transient failure.

The GitHub MacOS builds also failed.

The retry succeeded! But the Webhook is not going to pole CodeBuild again.
Which means only the macOS builds and test-clang-format need to be addressed.

@texastony texastony changed the title fix: C standard requires prototype (#807) fix: C standard requires prototype Nov 21, 2024
Unable to compile on Mac without a static cast to ensure the return
type of the thread id.
@dawesc dawesc force-pushed the fix-807-incompatible-pointer-only branch from 3cedb1a to 0c41d68 Compare November 22, 2024 10:51
@dawesc
Copy link
Author

dawesc commented Nov 22, 2024

Hi there, many thanks for your efforts; I've fixed the linting. Am I ok to leave the macOS install issue with you as it looks to be a problem with test environments? file cannot create directory: /usr/local/lib/cmake/AWSSDK. Maybe need administrative privileges.

@dawesc dawesc had a problem deploying to continuous-integration November 22, 2024 11:07 — with GitHub Actions Failure
@dawesc dawesc had a problem deploying to continuous-integration November 22, 2024 11:08 — with GitHub Actions Error
@texastony
Copy link
Contributor

I ran the MacOS CI on HEAD and got the same results;
it clearly is nothing related to this PR.
#809

@dawesc dawesc changed the title fix: C standard requires prototype fix: t_local_cache_threading.c:85:12: error: incompatible pointer to integer conversion Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants