Skip to content

Migrate "test/unit/test_providers_kms_master_key.py" from unittest to pytest #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 17, 2018
Merged

Migrate "test/unit/test_providers_kms_master_key.py" from unittest to pytest #121

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3e3e701
Migrating unit/test_deserialize.py from unittest from pytest
Dec 13, 2018
a070cb6
Migrate unit/test_provides_kms_master_key.py from unittest to pytest
Dec 13, 2018
91a1f09
Removed unit test not corresponding to this branch
Dec 13, 2018
41aeda3
Added yield and tearDown to apply_fixtures function
Dec 17, 2018
d0b1363
Lintering issues, fixed with tox -re autoformat
Dec 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 18 additions & 14 deletions test/unit/test_providers_kms_master_key.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,8 @@
# ANY KIND, either express or implied. See the License for the specific
# language governing permissions and limitations under the License.
"""Unit test suite for aws_encryption_sdk.key_providers.kms.KMSMasterKey"""
import unittest

import botocore.client
import pytest
import six
from botocore.exceptions import ClientError
from mock import MagicMock, patch, sentinel

Expand All @@ -30,8 +27,9 @@
pytestmark = [pytest.mark.unit, pytest.mark.local]


class TestKMSMasterKey(unittest.TestCase):
def setUp(self):
class TestKMSMasterKey(object):
@pytest.fixture(autouse=True)
def apply_fixture(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as #127 : need to run teardown actions.

self.mock_client = MagicMock()
self.mock_client.__class__ = botocore.client.BaseClient
self.mock_client.generate_data_key.return_value = {
Expand Down Expand Up @@ -59,13 +57,13 @@ def setUp(self):
key_id=VALUES["arn"], client=self.mock_client, grant_tokens=self.mock_grant_tokens
)
self.mock_kms_mkc_3 = KMSMasterKeyConfig(key_id="ex_key_info", client=self.mock_client)
yield
# Run tearDown
self.mock_data_key_len_check_patcher.stop()

def test_parent(self):
assert issubclass(KMSMasterKey, MasterKey)

def tearDown(self):
self.mock_data_key_len_check_patcher.stop()

def test_config_bare(self):
test = KMSMasterKeyConfig(key_id=VALUES["arn"], client=self.mock_client)
assert test.client is self.mock_client
Expand Down Expand Up @@ -111,14 +109,16 @@ def test_generate_data_key_with_grant_tokens(self):
def test_generate_data_key_unsuccessful_clienterror(self):
self.mock_client.generate_data_key.side_effect = ClientError({"Error": {}}, "This is an error!")
test = KMSMasterKey(config=self.mock_kms_mkc_3)
with six.assertRaisesRegex(self, GenerateKeyError, "Master Key .* unable to generate data key"):
with pytest.raises(GenerateKeyError) as excinfo:
test._generate_data_key(self.mock_algorithm)
excinfo.match("Master Key .* unable to generate data key")

def test_generate_data_key_unsuccessful_keyerror(self):
self.mock_client.generate_data_key.side_effect = KeyError
test = KMSMasterKey(config=self.mock_kms_mkc_3)
with six.assertRaisesRegex(self, GenerateKeyError, "Master Key .* unable to generate data key"):
with pytest.raises(GenerateKeyError) as excinfo:
test._generate_data_key(self.mock_algorithm)
excinfo.match("Master Key .* unable to generate data key")

def test_encrypt_data_key(self):
test = KMSMasterKey(config=self.mock_kms_mkc_3)
Expand Down Expand Up @@ -146,14 +146,16 @@ def test_encrypt_data_key_with_grant_tokens(self):
def test_encrypt_data_key_unsuccessful_clienterror(self):
self.mock_client.encrypt.side_effect = ClientError({"Error": {}}, "This is an error!")
test = KMSMasterKey(config=self.mock_kms_mkc_3)
with six.assertRaisesRegex(self, EncryptKeyError, "Master Key .* unable to encrypt data key"):
with pytest.raises(EncryptKeyError) as excinfo:
test._encrypt_data_key(self.mock_data_key, self.mock_algorithm)
excinfo.match("Master Key .* unable to encrypt data key")

def test_encrypt_data_key_unsuccessful_keyerror(self):
self.mock_client.encrypt.side_effect = KeyError
test = KMSMasterKey(config=self.mock_kms_mkc_3)
with six.assertRaisesRegex(self, EncryptKeyError, "Master Key .* unable to encrypt data key"):
with pytest.raises(EncryptKeyError) as excinfo:
test._encrypt_data_key(self.mock_data_key, self.mock_algorithm)
excinfo.match("Master Key .* unable to encrypt data key")

def test_decrypt_data_key(self):
test = KMSMasterKey(config=self.mock_kms_mkc_1)
Expand Down Expand Up @@ -186,11 +188,13 @@ def test_decrypt_data_key_with_grant_tokens(self):
def test_decrypt_data_key_unsuccessful_clienterror(self):
self.mock_client.decrypt.side_effect = ClientError({"Error": {}}, "This is an error!")
test = KMSMasterKey(config=self.mock_kms_mkc_3)
with six.assertRaisesRegex(self, DecryptKeyError, "Master Key .* unable to decrypt data key"):
with pytest.raises(DecryptKeyError) as excinfo:
test._decrypt_data_key(encrypted_data_key=self.mock_encrypted_data_key, algorithm=sentinel.algorithm)
excinfo.match("Master Key .* unable to decrypt data key")

def test_decrypt_data_key_unsuccessful_keyerror(self):
self.mock_client.decrypt.side_effect = KeyError
test = KMSMasterKey(config=self.mock_kms_mkc_3)
with six.assertRaisesRegex(self, DecryptKeyError, "Master Key .* unable to decrypt data key"):
with pytest.raises(DecryptKeyError) as excinfo:
test._decrypt_data_key(encrypted_data_key=self.mock_encrypted_data_key, algorithm=sentinel.algorithm)
excinfo.match("Master Key .* unable to decrypt data key")