Skip to content

chore: address linter concern #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 30, 2022

Conversation

texastony
Copy link
Contributor

Issue #, if available: Failing lint check

Description of changes:

  • Add timeout of 2 minutes to call
  • Pin linting dependencies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

Note:
The base-python and requirements file in a tox.ini
SHOULD be a consistent pair everywhere the
requirements is used.
@@ -164,7 +164,7 @@ commands =
examples/test/

[testenv:pylint]
basepython = python3
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note:
The base-python and requirements file in a tox.ini
SHOULD be a consistent pair everywhere the
requirements is used.

@texastony texastony marked this pull request as ready for review August 30, 2022 01:23
@texastony texastony requested a review from a team as a code owner August 30, 2022 01:23
@texastony texastony merged commit 75ae24a into aws:mainline-1.x Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants