Skip to content

Custom CloudFormation resources should gracefully handle stack creation rollbacks #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rbalman opened this issue Sep 24, 2019 · 2 comments

Comments

@rbalman
Copy link

rbalman commented Sep 24, 2019

Is your feature request related to a problem? Please describe.
Whenever a lambda backed custom resource creation fails, "github.com/aws/aws-lambda-go/cfn" returns a physicalResourceID to CloudFormation which doesn't exist. Then when CloudFormation tries to DELETE non-existent resource it fails. I have to manually skip the deletion of that particular custom resource to delete the Stack.

Describe the solution you'd like
Custom CloudFormation Resource should be able to be deleted like other normal Resources even though the CREATE event was not successful

Additional context

####### Here My Custom Resource is returning some ID when failed to create
Screen Shot 2019-09-24 at 11 24 34 AM

####### Here AWS Security Group returning nothing when failed to create

Screen Shot 2019-09-24 at 11 29 49 AM

Related PR

remind101/empire#918

@leepa
Copy link

leepa commented Sep 24, 2019

See #107 as that's why it was added. I didn't add it originally because of this though - removing it again or at least reverting #108 might be the sensible thing here.

@bmoffatt
Copy link
Collaborator

reverting #108 makes sense to me. We'll have to re-open #107 to solve the error-masking problem originally described there.

bmoffatt added a commit to bmoffatt/aws-lambda-go that referenced this issue Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants