Skip to content

CodePipelineEvent hardcoded to CodePipelineJob. #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
whithajess opened this issue Oct 28, 2019 · 1 comment
Open

CodePipelineEvent hardcoded to CodePipelineJob. #244

whithajess opened this issue Oct 28, 2019 · 1 comment
Labels
breaking change / v2 There is no plan for a v2 release! Alternative non-breaking approaches are strongly encouraged!

Comments

@whithajess
Copy link
Contributor

whithajess commented Oct 28, 2019

Is your feature request related to a problem? Please describe.

CodePipelineEvent seems to be hardcoded as a CodePipelineJob

This incorrectly makes CodePipeline event unusable for its actual events.

CodePipelineEvent documentation

Describe the solution you'd like

I would like to move the current CodePipelineEvent into its own CodePipelineJobEvent as it seems to be seperate then the documented CodePipelineEvents

Describe alternatives you've considered

Considered just leaving it as is and creating CodePipelineEvent under some new name like ActualCodePipelineEvent but I think this is one of those instances where it would be better to just make the change.

Additional context

Breaking Change

@bmoffatt bmoffatt added the breaking change / v2 There is no plan for a v2 release! Alternative non-breaking approaches are strongly encouraged! label Dec 3, 2019
@whithajess
Copy link
Contributor Author

@bmoffatt Just raising this again.

After 4 years this issue still exists, and anyone who uses this aws-lambda-go and CodePipelineEvent actually gets CodePipelineJobEvent completely unexpected and not matching the actual event or the rest of this codebase.

Is holding back doing SemVer changes really worth this? Wouldn't it have just been better to bump it?

I'm not currently doing anything with the library so it doesn't matter to me, but figured it might be worth reflecting on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change / v2 There is no plan for a v2 release! Alternative non-breaking approaches are strongly encouraged!
Projects
None yet
Development

No branches or pull requests

2 participants