Implement CodePipelineEvent #247
Conversation
* Incorrectly used "CodePipelineEvent"
* Reference docs: https://docs.aws.amazon.com/AmazonCloudWatch/latest/events/EventTypes.html#codepipeline_event_type * Test json from Reference Docs * Fix data issues from live testing vs real events
Codecov Report
@@ Coverage Diff @@
## master #247 +/- ##
=======================================
Coverage 74.59% 74.59%
=======================================
Files 20 20
Lines 681 681
=======================================
Hits 508 508
Misses 128 128
Partials 45 45Continue to review full report at Codecov.
|
events/codepipeline.go
Outdated
|
|
||
| // CodePipelineEvent is documented at: | ||
| // https://docs.aws.amazon.com/AmazonCloudWatch/latest/events/EventTypes.html#codepipeline_event_type | ||
| type CodePipelineEvent struct { |
There was a problem hiding this comment.
Suggest changing the name to CodePipelineCloudWatchEvent to disambiguate from CodePipelineJobEvent
Codecov Report
@@ Coverage Diff @@
## main #247 +/- ##
=======================================
Coverage 71.63% 71.63%
=======================================
Files 19 19
Lines 1040 1040
=======================================
Hits 745 745
Misses 228 228
Partials 67 67 Continue to review full report at Codecov.
|
|
@bmoffatt should now meet what you were after. |
| type CodePipelineEventDetail struct { | ||
| Pipeline string `json:"pipeline"` | ||
|
|
||
| // From live testing this is always int64 not string as documented |
There was a problem hiding this comment.
suspicious... example in docs appear inconsistent on this one across "Pipeline Execution State Change"/"Stage Execution State Change"/"Action Execution State Change"
There was a problem hiding this comment.
Ill just confirm this from real data as well as the one version left as a string on this line before I request re-review
Issue #, if available:
#246
Description of changes:
Implement CodePipeline Events from the official documentation:
Note: this includes code from #382 as it makes this cleaner.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.