-
Notifications
You must be signed in to change notification settings - Fork 564
handler.validateReturns() panics on function with no return value #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Feel free to create a PR to fix this up. Otherwise I'll make the change later this afternoon. |
dlsniper
added a commit
to dlsniper/aws-lambda-go
that referenced
this issue
Jan 16, 2018
This fixes a panic when invoking validateReturns() on a function without returns. Fixes aws#3
I've bumped into the same thing and I've sent #9 |
bmoffatt
pushed a commit
that referenced
this issue
Jan 16, 2018
This fixes a panic when invoking validateReturns() on a function without returns. Fixes #3
Thanks @dlsniper ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
The validateReturns method panics with runtime: index out of range for a handler function with no return value. Tested with go v1.9.2
Adding this test case in
lambda/handler_test.go
:results in
Line 63 in handler.go needs to check for at least one return value before performing the type check.
The text was updated successfully, but these errors were encountered: