Add support for multi-value parameters in API Gateway proxy events #136
Conversation
* Add multiValueHeaders * Add multiValueQueryStringParameters * Add requestContext.identity.accessKey
Codecov Report
@@ Coverage Diff @@
## master #136 +/- ##
=======================================
Coverage 69.65% 69.65%
=======================================
Files 17 17
Lines 715 715
=======================================
Hits 498 498
Misses 173 173
Partials 44 44Continue to review full report at Codecov.
|
piotrkubisa
changed the title
piotrkubisa
changed the title
|
Yesterday I found also a blog post about multi-value parameters on the AWS Compute Blog https://aws.amazon.com/blogs/compute/support-for-multi-value-parameters-in-amazon-api-gateway/ Is there anything what I can do in this PR to help you introduce this change to the |
|
I haven't dove too deeply into the testing of this package but it seems like you did change some test data json files. If you updated the tests that relied on those files to check for the new properties ( |
| @@ -42,7 +66,8 @@ | |||
| "accountId": "theAccountId", | |||
| "cognitoIdentityId": "theCognitoIdentityId", | |||
| "caller": "theCaller", | |||
| "apiKey": "theApiKey", | |||
| "apiKey": "theApiKey", | |||
| "accessKey": "ANEXAMPLEOFACCESSKEY", | |||
There was a problem hiding this comment.
thanks for adding this as well
|
LGTM, thanks! |
Recently I was digging more into Lambda environment and I found new fields which are not defined in
aws-lambda-gostruct for API Gateway Proxy Request event:events.APIGatewayProxyRequest.MultiValueHeaders.events.APIGatewayProxyRequest.MultiValueQueryStringParameters.events.APIGatewayRequestIdentity.AccessKey(populated whether doing an authorization using AWS credentials).https://aws.amazon.com/about-aws/whats-new/2018/10/amazon-api-gateway-adds-support-for-multi-parameters/
Maintainers: do we need any extra unit test for these new fields?