Skip to content

Update alb test data #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions events/alb.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@ package events
type ALBTargetGroupRequest struct {
HTTPMethod string `json:"httpMethod"`
Path string `json:"path"`
QueryStringParameters map[string]string `json:"queryStringParameters"`
MultiValueQueryStringParameters map[string][]string `json:"multiValueQueryStringParameters"`
Headers map[string]string `json:"headers"`
MultiValueHeaders map[string][]string `json:"multiValueHeaders"`
QueryStringParameters map[string]string `json:"queryStringParameters,omitempty"`
MultiValueQueryStringParameters map[string][]string `json:"multiValueQueryStringParameters,omitempty"`
Headers map[string]string `json:"headers,omitempty"`
MultiValueHeaders map[string][]string `json:"multiValueHeaders,omitempty"`
RequestContext ALBTargetGroupRequestContext `json:"requestContext"`
IsBase64Encoded bool `json:"isBase64Encoded"`
Body string `json:"body"`
Expand Down
37 changes: 21 additions & 16 deletions events/alb_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,25 +10,30 @@ import (
)

func TestALBTargetRequestMarshaling(t *testing.T) {
// read json from file
inputJSON, err := ioutil.ReadFile("./testdata/alb-lambda-target-request.json")
if err != nil {
t.Errorf("could not open test file. details: %v", err)
}
inputFiles := []string{
"./testdata/alb-lambda-target-request-headers-only.json",
"./testdata/alb-lambda-target-request-multivalue-headers.json"}

// de-serialize into Go object
var inputEvent ALBTargetGroupRequest
if err := json.Unmarshal(inputJSON, &inputEvent); err != nil {
t.Errorf("could not unmarshal event. details: %v", err)
}
for _, filename := range inputFiles {
// read json from file
inputJSON, err := ioutil.ReadFile(filename)
if err != nil {
t.Errorf("could not open test file. details: %v", err)
}

// serialize to json
outputJSON, err := json.Marshal(inputEvent)
if err != nil {
t.Errorf("could not marshal event. details: %v", err)
}
// de-serialize into Go object
var inputEvent ALBTargetGroupRequest
if err := json.Unmarshal(inputJSON, &inputEvent); err != nil {
t.Errorf("could not unmarshal event. details: %v", err)
}

assert.JSONEq(t, string(inputJSON), string(outputJSON))
// serialize to json
outputJSON, err := json.Marshal(inputEvent)
if err != nil {
t.Errorf("could not marshal event. details: %v", err)
}
assert.JSONEq(t, string(inputJSON), string(outputJSON))
}
}

func TestALBTargetRequestMalformedJson(t *testing.T) {
Expand Down
26 changes: 26 additions & 0 deletions events/testdata/alb-lambda-target-request-headers-only.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
{
"requestContext": {
"elb": {
"targetGroupArn": "arn:aws:elasticloadbalancing:us-east-1:123456789012:targetgroup/lambda-target/abcdefg"
}
},
"httpMethod": "GET",
"path": "/",
"queryStringParameters": {
"key": "hello"
},
"headers": {
"accept": "*/*",
"connection": "keep-alive",
"host": "lambda-test-alb-1334523864.us-east-1.elb.amazonaws.com",
"user-agent": "curl/7.54.0",
"x-amzn-trace-id": "Root=1-5c34e93e-4dea0086f9763ac0667b115a",
"x-forwarded-for": "25.12.198.67",
"x-forwarded-port": "80",
"x-forwarded-proto": "http",
"x-imforwards": "20",
"x-myheader": "123"
},
"body": "",
"isBase64Encoded": false
}
48 changes: 48 additions & 0 deletions events/testdata/alb-lambda-target-request-multivalue-headers.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
{
"requestContext": {
"elb": {
"targetGroupArn": "arn:aws:elasticloadbalancing:us-east-1:123456789012:targetgroup/lambda-target/abcdefgh"
}
},
"httpMethod": "GET",
"path": "/",
"multiValueQueryStringParameters": {
"key": [
"hello"
]
},
"multiValueHeaders": {
"accept": [
"*/*"
],
"connection": [
"keep-alive"
],
"host": [
"lambda-test-alb-1234567.us-east-1.elb.amazonaws.com"
],
"user-agent": [
"curl/7.54.0"
],
"x-amzn-trace-id": [
"Root=1-5c34e7d4-00ca239424b68028d4c56d68"
],
"x-forwarded-for": [
"72.21.198.67"
],
"x-forwarded-port": [
"80"
],
"x-forwarded-proto": [
"http"
],
"x-imforwards": [
"20"
],
"x-myheader": [
"123"
]
},
"body": "",
"isBase64Encoded": false
}
50 changes: 0 additions & 50 deletions events/testdata/alb-lambda-target-request.json

This file was deleted.