Add missing links to READMEs #403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iph
reviewed
Oct 30, 2021
events/README.md
Outdated
Comment on lines
29
to
33
| [CodeBuild Events](README_CodeBuild.md) | ||
|
|
||
| [Code Commit Events](README_CodeCommit.md) | ||
|
|
||
| [CodeDeploy Events](README_CodeDeploy.md) |
There was a problem hiding this comment.
Just to be consistent with Code Commit, should these be Code Build Events and Code Deploy Events?
There was a problem hiding this comment.
on the other hand, aws console presents these three without spaces, can update Code Commit Events to CodeCommit Events
iph
reviewed
Oct 30, 2021
Codecov Report
@@ Coverage Diff @@
## main #403 +/- ##
=======================================
Coverage 71.63% 71.63%
=======================================
Files 19 19
Lines 1040 1040
=======================================
Hits 745 745
Misses 228 228
Partials 67 67 Continue to review full report at Codecov.
|
bmoffatt
approved these changes
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated events/README.md